Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more triggers to scroll asks to bottom in pro orderbook #2455

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 13, 2024

DocAgnew on discord reported cases where the asks (in red) for the pro orderbook would not scroll to the bottom so the center point price in the bid/ask lists were tightened.

This PR adds a few additional triggers and timer delays to ensure this scroll is enforced once orderbook loads when

  • flipping pair
  • changing pair
  • changing buy/sell mode
  • loading dex pro tab.

To test:

  • login and go to pro screen.
  • select a pair with enough orders to extend the list beyond the window (e.g. KMD/LTC)
  • flip the pair, change the pair, change buy to sell change tab and change back. For all of these the values in the top sectiopn oif the orderbook (in red) should scroll down fairly quickly after loading so that the values at the bottom of the red list are as close to the values at the top of the green list as possible.

For example: This is good
image

And this is not (unless manually scrolled after loading)
image

cipig
cipig previously approved these changes Jun 13, 2024
@cipig
Copy link
Member

cipig commented Jun 13, 2024

@smk762 smk762 merged commit d92d7b7 into dev Jun 21, 2024
6 checks passed
@smk762 smk762 mentioned this pull request Jun 21, 2024
@ca333 ca333 deleted the orderbook-divergence branch October 23, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants